[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v1 Altp2m cleanup 2/3] Move altp2m specific functions to altp2m files.
>>> On 21.06.16 at 18:04, <paul.c.lai@xxxxxxxxx> wrote: > @@ -65,6 +66,48 @@ altp2m_vcpu_destroy(struct vcpu *v) > vcpu_unpause(v); > } > > +int > +hvm_altp2m_init( struct domain *d) { Coding style (stray blank and misplaced brace). > + int rv = 0; I guess rc or ret would be the more conventional names. > + unsigned int i = 0; Pointless initializer. > + /* Init alternate p2m data */ Missing full stop. > --- a/xen/arch/x86/mm/p2m-ept.c > +++ b/xen/arch/x86/mm/p2m-ept.c > @@ -1329,6 +1329,44 @@ void setup_ept_dump(void) > register_keyhandler('D', ept_dump_p2m_table, "dump VT-x EPT tables", 0); > } > > +void p2m_init_altp2m_helper( struct domain *d, unsigned int i) { While moving it here, please adjust the name to make clear this is EPT specific. Also it looks like the first parameter could become const. > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -196,8 +196,8 @@ static void p2m_teardown_altp2m(struct domain *d) > if ( !d->arch.altp2m_p2m[i] ) > continue; > p2m = d->arch.altp2m_p2m[i]; > - d->arch.altp2m_p2m[i] = NULL; > p2m_free_one(p2m); > + d->arch.altp2m_p2m[i] = NULL; > } Why, without any other changes (you're only moving code around)? > @@ -37,5 +36,7 @@ static inline uint16_t altp2m_vcpu_idx(const struct vcpu *v) > { > return vcpu_altp2m(v).p2midx; > } > +int hvm_altp2m_init(struct domain *d); > +void hvm_altp2m_teardown(struct domain *d); Missing separating blank line. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |