Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 29/06/16 13:44, Juergen Gross wrote:
> @@ -2068,13 +1964,6 @@ int main(int argc, char *argv[])
>       /* Tell the kernel we're up and running. */
>       xenbus_notify_running();
>  
> -#if defined(XEN_SYSTEMD_ENABLED)
> -     if (systemd) {
> -             sd_notify(1, "READY=1");
> -             fprintf(stderr, SD_NOTICE "xenstored is ready\n");
> -     }
> -#endif

Getting rid of the socket configuration for systemd is ok, but we should
keep the sd_notify() calls for when the daemon is started by systemd.

Socket activiation and sd_notify() are orthogonal, and sd_notify() is
still required if we don't want systemd to treat xenstored as a legacy
unix daemon.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel