Re: [Xen-devel] [PATCH] vm-event: MAINTAINERS fix

[Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>]

On 7/1/2016 10:27 AM, Jan Beulich wrote:
> > > > On 01.07.16 at 09:15, <czuzu@xxxxxxxxxxxxxxx> wrote:
> > Fix vm-event section of MAINTAINERS file.
> Would be nice to mention here which commit(s) caused these to go
> out of sync with the actual code.
Why?

> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -402,10 +402,14 @@ M:        Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> >   M:    Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> >   S:    Supported
> >   F:    xen/common/mem_access.c
> > -F:     xen/*/vm_event.c
> > -F:     xen/*/monitor.c
> > +F:     xen/common/vm_event.c
> > +F:     xen/arch/*/vm_event.c
> > +F:     xen/common/monitor.c
> > +F:     xen/arch/*/monitor.c
> > +F:     xen/arch/x86/hvm/monitor.c
> >   F:    xen/include/*/mem_access.h
> >   F:    xen/include/*/monitor.h
> > +F:     xen/include/asm-x86/hvm/monitor.h
> >   F:    xen/include/*/vm_event.h
> >   F:    tools/tests/xen-access
> Please at least don't make (un)sorted-ness worse than it was.
>
> Jan
Please at least mention how these were sorted (/unsorted). They are 
currently sorted, just not alphabetically (common before arch, grouped 
by file, .c before .h).
How do you want me to sort them? Be specific (and don't make me guess 
the rules, where is this written? if not written anywhere, how should I 
adjust CODE_STYLE to fix that?).
Corneliu.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel