[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 11/17] libxl/arm: Construct ACPI DSDT table



Hi Boris,

On 01/07/16 15:42, Boris Ostrovsky wrote:
On 07/01/2016 06:18 AM, Julien Grall wrote:
On 01/07/16 08:58, Shannon Zhao wrote:
On 2016/6/30 2:58, Boris Ostrovsky wrote:
git://oss.oracle.com/git/bostrovs/xen.git:acpi_v1_wip

[...]

Looks like Boris is going to use libxl__dom_load_acpi to load ACPI
tables, do we need to use it for ARM as well or load the tables in
xc_dom_build_image()?

I gave a quick look to the code and it is very similar to ARM for the
allocation of the memory and copying the ACPI tables. So we may want
to share some bits here.

I have the feeling it would be better to do it in libxc where all the
guest memory is handled. But I will let the tools maintainers decide
where this should be done.

Haven't we decided that libxl is the better place?

The discussion was related to building the ACPI tables. I consider loading the blob into memory as distinct step.

Currently, the memory layout and loading blobs into the memory is handled by libxc (see xc_dom_build_image). It would be rather strange to load the ACPI tables in libxl.

For what is worth, on ARM the device tree is built by libxl and loaded by libxc.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.