Re: [Xen-devel] [PATCH] mini-os: replace lib/printf.c with a version not under GPL

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Hello,

Juergen Gross, on Fri 01 Jul 2016 11:33:27 +0200, wrote:
> Instead of a Linux kernel based implementation use one from freeBSD.

That'd be useful indeed :)

> I'm not sure about coding style here: should I keep (more or less) the
> one from freeBSD, or is the Xen style preferred?

I'd say just keep the file as it is upstream, so we can sync more easily
in the future.

> diff --git a/include/lib-gpl.h b/include/lib-gpl.h
> index d5602b2..7557627 100644
> --- a/include/lib-gpl.h
> +++ b/include/lib-gpl.h

Please move the content to lib.h then, since it won't be gpl any more.

Did you check the boot output e.g. of a trivial mini-os application?
Notably, iirc there were perhaps odd formating with %x, %p or such.
Moving to the posix behavior would be a good thing, I'd just want to
know whether we have some behavior change.

Thanks,
Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel