Re: [Xen-devel] [PATCH v13 1/3] IOMMU/x86: use a struct pci_dev* instead of SBDF

["Xu, Quan" <quan.xu@xxxxxxxxx>]

On July 04, 2016 1:35 PM, Tian, Kevin <kevin.tian@xxxxxxxxx> wrote:
> > From: Xu, Quan
> > Sent: Wednesday, June 29, 2016 2:00 PM
> >
> > From: Quan Xu <quan.xu@xxxxxxxxx>
> >
> > A struct pci_dev* instead of SBDF is stored inside struct pci_ats_dev
> > and parameter to *_ats_device().
> >
> > Also use ats_dev for "struct pci_ats_dev" variable, while pdev (_pdev,
> > if there is already a pdev) for "struct pci_dev"
> > in the scope of IOMMU.
> >
> > Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> >
> > CC: Jan Beulich <jbeulich@xxxxxxxx>
> > CC: Kevin Tian <kevin.tian@xxxxxxxxx>
> > CC: Feng Wu <feng.wu@xxxxxxxxx>
> > CC: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> >
> 
> Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>, with one minor comment:
> 
> > diff --git a/xen/drivers/passthrough/amd/iommu_cmd.c
> > b/xen/drivers/passthrough/amd/iommu_cmd.c
> > index 7c9d9be..934977a 100644
> > --- a/xen/drivers/passthrough/amd/iommu_cmd.c
> > +++ b/xen/drivers/passthrough/amd/iommu_cmd.c
> > @@ -294,28 +294,27 @@ void amd_iommu_flush_iotlb(u8 devfn, const
> > struct pci_dev *pdev,
> >      if ( !ats_enabled )
> >          return;
> >
> > -    ats_pdev = get_ats_device(pdev->seg, pdev->bus, pdev->devfn);
> > +    ats_pdev = get_ats_device(pdev);
> >      if ( ats_pdev == NULL )
> >          return;
> >
> 
> To align with other places, better to change ats_pdev to ats_dev too.


Indeed,  thanks very much!!
I will update it soon.
- Quan 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel