Re: [Xen-devel] [PATCH] xen: arm64: Add support for Renesas RCar Gen3 H3 Salvator-X platform

[Julien Grall <julien.grall@xxxxxxx>]

(CC Wei for the release part)

Hi Dirk,

On 04/07/16 07:51, Dirk Behme wrote:
> Signed-off-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>
Thank you for adding support of a new board in Xen.

During the last hackathon, we discussed about improving pre-release 
testing on ARM hardware [1] and helping users to boot Xen on supported 
board.
This patch is the first board officially supported since then, so I 
would like to start applying what was discussed (I will put on a wiki 
page later). Below the list of things that I would like to see when a 
new board is added:
   - Create a wiki page to explain the requirements to boot Xen on the 
board (e.g new firmware if not supported out of box, linux version,...);
   - Add a link to the new page in [2];
   - Add the contact details in [3] of someone who would could test 
pre-release and help out users to boot Xen on the board.
I do not expect the latter point to be time consuming. It is basically 
checking if Xen boots before each release and possibly update the 
requirements of the board. For the part helping users, it will mostly be 
question related to booting Xen on the hardware. Others may not be able 
to answer because they do not have the board on their desk.
In the future, I would like to see Xen tested before each release on all 
the boards officially supported. If it was not tested, we will consider 
the board as not supported.
[...]

> diff --git a/xen/arch/arm/platforms/rcar3.c b/xen/arch/arm/platforms/rcar3.c
> new file mode 100644
> index 0000000..5a53f15
> --- /dev/null
> +++ b/xen/arch/arm/platforms/rcar3.c
> @@ -0,0 +1,41 @@
> +/*
> + * xen/arch/arm/platforms/rcar3.c
> + *
> + * Renesas R-Car Gen3 specific settings
> + *
> + * Dirk Behme <dirk.behme@xxxxxxxxxxxx>
> + *
> + * based on Renesas R-Car Gen2 specific settings
> + * Iurii Konovalenko <iurii.konovalenko@xxxxxxxxxxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <asm/platform.h>
> +
> +static const char const *rcar3_dt_compat[] __initdata =
> +{
> +    "renesas,salvator-x",
> +    NULL
> +};
> +
> +PLATFORM_START(rcar3, "Renesas R-Car Gen3")
> +    .compatible = rcar3_dt_compat,
Your platform does not seem to require specific bring-up code, so this 
file can be dropped.
> +PLATFORM_END
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
Regards,

[1] 
http://lists.xenproject.org/archives/html/xen-devel/2016-03/msg03683.html
[2] 
http://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions#Hardware
[3] http://wiki.xenproject.org/wiki/Xen_ARM_Manual_Smoke_Test/Results

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel