Re: [Xen-devel] [PATCH RFC v1 09/14] Makefile: delete STUBDOMPATH target

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jul 05, 2016 at 01:53:22PM +0000, Xu, Quan wrote:
> Wei,
> I have spent a lot of days to clean up the code of vtpm / vtpmmgr. but there 
> are tricky issue to boot domu on TPM2.0..
> So I am afraid I can't finish it as today is my last working day at intel.
> 
> Now, these patch are on https://github.com/virt2x/vtpm2vtpmmgr 
> Sorry for that.

No need to be sorry. Thanks for letting us know.

Last but not least, thanks for your contribution to Xen and all the best
with your new journey!

Wei.

> Quan
> 
> On April 01, 2016 6:03 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > On Fri, Apr 01, 2016 at 01:41:40AM +0000, Xu, Quan wrote:
> > > On March 31, 2016 9:50pm, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > > > On Thu, Mar 31, 2016 at 10:21:22AM +0000, Xu, Quan wrote:
> > > > > On March 11, 2016 12:53am, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> > > > > > -build: $(STUBDOMPATH)
> > > > > > +build: $(STUBDOM_BUILD)
> > > > >
> > > > > Wei,
> > > > > in original code, in stubdom/vtpm and stubdom/vtpmmgr, the code
> > > > > style is inconsistent and ugly.
> > > > I personally prefer small patches in a series, but I don't object to
> > > > having large
> > > > patch(es) either.
> > >
> > > ok. I think so too. It may be one file per patch.
> > >
> > >
> > > > At the end of the day, I think Daniel's opinion matters most.
> > > > After a plan is agreed upon, you can then provide a branch for us to 
> > > > pull in.
> > >
> > > I think I am not authorized to branch, could you provide a branch and 
> > > tell me
> > how to commit to that branch?
> > > Sorry, I am unfamiliar with the upstream process.
> > >
> > 
> > Oh, you don't need to branch on the main tree (xen.git or future 
> > stubdom.git).
> > You can just do the following:
> > 
> >   $ git clone xen.git # or stubdom.git
> >   $ cd xen.git # or stubdom.git
> >   $ git branch wip.vtpm-coding-style-fix-v1
> >   ... do work, commit as you go alone ...
> >   $ git push $some_public_remote wip.vtpm-coding-style-fix-v1
> >   ... post your patch series on xen-devel, along with the git repository
> >   and branch
> > 
> > When your patches are all acked by Daniel, you can then fold all the tags 
> > into
> > your own branch (wip.vtpm-coding-style-fix-v$X-acked)
> > and prod committers to pull from that branch.
> > 
> > > > Note
> > > > that upstream don't test vtpm in any fashion so you do need to run your
> > tests.
> > > >
> > > I will test it. I think I hope Daniel could help my patches.
> > > btw, I have made a quick patch to fix the seal/unseal issue. I will send 
> > > out
> > later.
> > >
> > > > The only thing that matters to me is that when you will do it -- you
> > > > will need to patch a different tree after I split off stubdom. In
> > > > order to minimise the fuss one of us will need to wait for the other.
> > > >
> > > Once you have done, please let me know.
> > 
> > OK, I will try to sort it out within April.  Feel free to ping me if I drop 
> > the ball.
> > 
> > Wei.
> > 
> > > Quan
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxx
> > http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel