Re: [Xen-devel] [PATCH v2 4/5] libxl: introduce APIs to get and set log level

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH v2 4/5] libxl: introduce APIs to get and set log 
level"):
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
...
> +int libxl_set_log_level(libxl_ctx *ctx, bool guest,
> +                        char *lower_thresh, char *upper_thresh)

I think the log level names should be exposed as a list to the
caller.  It might be better to allow the caller to specify an integer.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel