Re: [Xen-devel] [PATCH 1/2] xenbus: don't bail early from xenbus_dev_request_and_reply()

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 07/07/16 08:32, Jan Beulich wrote:
> We must not skip the transaction_end() call for a failed
> XS_TRANSACTION_START. The removed code fragment got introduced by
> commit 027bd7e899 ("xen/xenbus: Avoid synchronous wait on XenBus
> stalling shutdown/restart") without its description really indicating
> why it was added (and hence I can't identify whether a more complex
> change might be needed here).

If sending the XS_TRANSACTION_END message failed, then the transaction
is still open and transaction_end() should not be called.

However, if sending an XS_TRANSACTION_START failed, then
transaction_end() should be called.

So, yes a more complex fix is needed here.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel