Re: [Xen-devel] [PATCH v2] tools/hotplug: Add native systemd xendriverdomain.service

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 07, 2016 at 02:09:32PM +0000, Rusty Bird wrote:
> A dedicated Xen driver domain init service starts "xl devd" in domU. But
> currently, it is only supplied in the form of a SysV init script, which
> systemd users run through a backward compatiblity wrapper automatically
> generated by systemd-sysv-generator. This patch adds a (naturally more
> lightweight) native systemd unit to be used instead.
> 
> The xendriverdomain service is only relevant to domU, but should not run
> in dom0. Therefore, the systemd unit uses "ConditionVirtualization=xen",
> which evaluates to true in domU and (since systemd version 214, released
> on 2014-06-11) to false in dom0. Users or distributors who need to be
> compatible with even older systemd versions, but still want to prevent
> "xl devd" startup in dom0, could add the following line in [Service]:
> ExecStartPre=/bin/sh -c "! grep -q control_d /proc/xen/capabilities"
> 
> (Please rerun autogen.sh after applying this patch)
> 
> Signed-off-by: Rusty Bird <rustybird@xxxxxxxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>

Thanks, the commit message is clearer now.

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

> ---
> Changed since v1:
>   * more detailed commit message
> 
>  tools/configure.ac                                     |  1 +
>  tools/hotplug/Linux/systemd/Makefile                   |  1 +
>  tools/hotplug/Linux/systemd/xendriverdomain.service.in | 14 ++++++++++++++
>  3 files changed, 16 insertions(+)
>  create mode 100644 tools/hotplug/Linux/systemd/xendriverdomain.service.in
> 
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 8704927..e08fa8e 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -437,6 +437,7 @@ AS_IF([test "x$systemd" = "xy"], [
>      hotplug/Linux/systemd/xenconsoled.service
>      hotplug/Linux/systemd/xendomains.service
>      hotplug/Linux/systemd/xenstored.service
> +    hotplug/Linux/systemd/xendriverdomain.service

I failed to mention that I would like to sort this list alphabetically,
i.e. the new addition should be moved before xenstored.service.  I can
make the adjustment while committing if you don't object.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel