Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 07/08/2016 06:55 AM, Wei Liu wrote:
>
>> +
>> +    /* Map page that will hold RSDP */
>> +    extent = RSDP_ADDRESS >> ctxt.page_shift;
>> +    rc = populate_acpi_pages(dom, &extent, 1, &ctxt);
>> +    if (rc) {
>> +        LOG(ERROR, "%s: populate_acpi_pages for rsdp failed with %d",
>> +            __FUNCTION__, rc);
>> +        goto out;
>> +    }
>> +    config.rsdp = (unsigned long)xc_map_foreign_range(xch, domid,
>> +                                                      ctxt.page_size,
>> +                                                      PROT_READ | 
>> PROT_WRITE,
>> +                                                      RSDP_ADDRESS >> 
>> ctxt.page_shift);
> I think with Anthony's on-going work you should be more flexible for all
> you tables.

Not sure I understand what you mean here. You want the address
(RSDP_ADDRESS) to be a variable as opposed to a macro?

>
> I haven't really looked into details for this patch. Let's sort out
> the linkage issue between GPLv2 cod and LGPL code first.


Ugh.. Yes, this one didn't even cross my mind until you brought it up
yesterday.

What are the options? Can we dual-license those files as GPLv2/LGPL,
assuming copyright holders --- Keir (or Citrix?) and Intel --- agree?

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel