Re: [Xen-devel] [PATCH v1 13/20] acpi/hvmloader: Include file/paths adjustments

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.07.16 at 21:05, <boris.ostrovsky@xxxxxxxxxx> wrote:
> x86-specific definitions are kept locally in x86.h. I wonder, however, 
> whether this
> should go somewhere in xen/include/public/<arch>. See, for example, patch 19
> that demonstrates that having x86.h live in libacpi.h may not be such a 
> great idea.

None of what you put there in this patch looks like a candidate for
becoming part of the public interface.

> @@ -22,3 +30,4 @@ DSDT compiler "iasl" is needed. By default, it will be 
> downloaded
>  using wget in Makefile. if it failed, please download manually from 
>  http://developer.intel.com/technology/iapc/acpi/downloads.htm. 
>  then compile and install iasl
> +

Please don't.

> --- a/tools/firmware/hvmloader/hvmloader.c
> +++ b/tools/firmware/hvmloader/hvmloader.c
> @@ -24,8 +24,9 @@
>  #include "config.h"
>  #include "pci_regs.h"
>  #include "apic_regs.h"
> -#include "acpi/acpi2_0.h"
> +#include "acpi2_0.h"

Is this really still needed here an in all of the further places where
you convert its path? I'd generally expect libacpi.h to be the only
interface needed now.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel