[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3/6] xenconsoled: switch guest log to use logfile abstraction

To: Wei Liu <wei.liu2@xxxxxxxxxx>
From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date: Fri, 8 Jul 2016 18:01:34 +0100
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 08 Jul 2016 17:01:42 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

Wei Liu writes ("[PATCH 3/6] xenconsoled: switch guest log to use logfile 
abstraction"):
> Note that this causes write_with_timestamp to have no caller. Mark
> it as unused for now to minimise code churn.

This is plausible, although I think I would have structured this
series differently.  (1. provide new api to old code; 2. switch
everyone to new api; 3. replace implementation.)

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

Prev by Date: Re: [Xen-devel] [PATCH v3] xen/arm: enable clocks used by the hypervisor
Next by Date: Re: [Xen-devel] [PATCH 4/6] xenconsoled: delete two now unused functions
Previous by thread: Re: [Xen-devel] [PATCH 2/6] xenconsoled: switch hypervisor log to use logfile abstraction
Next by thread: Re: [Xen-devel] [PATCH 4/6] xenconsoled: delete two now unused functions
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.