Re: [Xen-devel] [PATCH 2/7] tools/helper: honour XEN_RUN_DIR in init-xenstore-domain.c

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH 2/7] tools/helper: honour XEN_RUN_DIR in 
init-xenstore-domain.c"):
> Place the PID file under XEN_RUN_DIR. Note that this change the default
> location from /var/run to /var/run/xen.
> 
> Generate a _paths.h as that is required to make this change work.
...
> -init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS)
> +init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS) _paths.h

This dependency is surely wrong.  It is the object(s) (ie, the
compile) that depend on _paths.h, not the executable (ie the link).

But otherwise this is fine.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel