Re: [Xen-devel] [PATCH v3 7/8] arm/atomic.h: remove '__' prefix for __atomic_add_unless()

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 14 Jul 2016, Corneliu ZUZU wrote:
> On 7/14/2016 1:00 PM, Julien Grall wrote:
> > Hi Corneliu,
> > 
> > On 14/07/16 10:14, Corneliu ZUZU wrote:
> > > The built-in leading underscores ('__') don't serve any purpose, so rename
> > > __atomic_add_unless() -> atomic_add_unless().
> > 
> > The leading underscores are from the Linux code. We decided to keep those
> > files unmodified to help syncing atomic code.
> > 
> > So I am not in favor of dropping the '__'. If you want to use these
> > functions in the common code, then a wrapper in "asm-arm/atomic.h" should be
> > introduced.
> > 
> > Regards,
> 
> Ok, great. Either add a wrapper or maybe keeping the underscores on X86 too
> and not including it's prototype in <xen/atomic.h>. What would you prefer?

Add a wrapper

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel