Re: [Xen-devel] [PATCH v2 1/5] asm-arm/atomic.h: fix arm32|arm64 macros duplication

[Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>]

On 7/14/2016 1:14 PM, Julien Grall wrote:
> On 14/07/16 11:11, Corneliu ZUZU wrote:
> > On 7/14/2016 12:26 PM, Julien Grall wrote:
> > > On 14/07/16 06:11, Corneliu ZUZU wrote:
> > > > On 7/13/2016 10:12 PM, Julien Grall wrote:
> > > > > Hi Corneliu,
> > > > >
> > > > > On 13/07/2016 15:18, Corneliu ZUZU wrote:
> > > > > > Move duplicate macros between asm-arm/arm32/atomic.h and
> > > > > > asm-arm/arm64/atomic.h
> > > > > > to asm-arm/atomic.h.
> > > > > asm-arm/arm*/atomic.h were a copy from Linux. I don't mind if we
> > > > > diverge, however the file xen/arch/arm/README.primitives needs to be
> > > > > update to mention the divergence with Linux.
> > > > >
> > > > > Regards,
> > > > Julien,
> > > >
> > > > AFAICT the README.LinuxPrimitives file specifies the Linux kernel
> > > > version from which the arm{32,64}/atomic.h files were imported as well
> > > > as the respective commit in the -Linux kernel- tree. I suppose that
> > > > information needn't be updated.
> > > > Could you be more specific on how I should modify that file?
> > > To specify which helpers has been taken from Linux in those files.
> > > Until now, it was quite easy to figure out that we took all atomic_*
> > > helpers.
> > >
> > > Regards,
> >
> > Ok, will look into that.
> >
> > I suppose also adding:
> >
> > diff -u linux/arch/arm64/include/asm/atomic.h
> > xen/include/asm-arm/arm64/atomic.h
> > diff -u linux/arch/arm/include/asm/atomic.h
> > xen/include/asm-arm/arm32/atomic.h
> >
> > as it's done for the others helps?
> No, the other files are a verbatim copy of the Linux headers. It is 
> not the case here.
> Something like:
>
> "Only the following functions were taken from Linux:
>   - ...
>   - ...
>   - ...
> "
>
> Regards,
Well, weren't they all taken from Linux?..I just turned some of the 
macros into inline functions and implemented some missing (no 
additional) ones on the X86-side.
Corneliu.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel