Re: [Xen-devel] [PATCH 2/3] xen: Have schedulers revise initial placement

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 15/07/16 19:02, George Dunlap wrote:
> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index 3b9aa27..5a04985 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -1620,15 +1620,23 @@ csched2_vcpu_insert(const struct scheduler *ops, 
> struct vcpu *vc)
>  
>      BUG_ON(is_idle_vcpu(vc));
>  
> +    /* Locks in cpu_pick expect irqs to be disabled */
> +    local_irq_disable();

This doesn't make the problem much worse, but is there a plan to fix
this issue?

None of the scheduler-accounting functions should be disabling interrupts.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel