[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] XSM-docs: Flask operates on domain types and not on individual domain. Updated the documentation to reflect this.


  • To: anshul makkar <anshul.makkar@xxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
  • Date: Tue, 19 Jul 2016 11:29:48 -0400
  • Delivery-date: Tue, 19 Jul 2016 15:30:10 +0000
  • Ironport-phdr: 9a23:vqqBDxQLpeAA3OLAhVYShL9KUdpsv+yvbD5Q0YIujvd0So/mwa65YRCN2/xhgRfzUJnB7Loc0qyN4vimBDVLscrJmUtBWaQEbwUCh8QSkl5oK+++Imq/EsTXaTcnFt9JTl5v8iLzG0FUHMHjew+a+SXqvnYsExnyfTB4Ov7yUtaLyZ/mj6bvotaDP01hv3mUWftKNhK4rAHc5IE9oLBJDeIP8CbPuWZCYO9MxGlldhq5lhf44dqsrtY4q3wD89pozcNLUL37cqIkVvQYSW1+ayFm2dfv/SXnYUPPoyFEEzZerh0dCg7e7Az+FpL4sSjzrKIp0S+BPdDyC7U9Wjer9Y9gSQPyiTdBPDk8piWfpsttg+p0pxatvABywoicNIqcLvZ5c4vWdMkWQmcHVcFUAWgJEo66KocCEecFFeJZtJXm4UsDq125Hwb/Kvnoz2pkj3n30Kly/+lpPhvP1QJoS94BvHnbttzdKLYZUefzyrLBizrEcaUFin/G9IHUf0V58rm3VrVqfJ+UkBN3Gg==
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 07/19/2016 11:21 AM, anshul makkar wrote:
On 19/07/16 14:30, Doug Goldstein wrote:
On 7/19/16 4:05 AM, Anshul Makkar wrote:
Signed-off-by: Anshul Makkar <anshul.makkar@xxxxxxxxxx>
---
  * Resending the patch due to incomplete subject in the previous patch.

  docs/misc/xsm-flask.txt | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/docs/misc/xsm-flask.txt b/docs/misc/xsm-flask.txt
index 62f15dd..bf8bb6e 100644
  Some examples of what FLASK can do:
- - Prevent two domains from communicating via event channels or grants
- - Control which domains can use device passthrough (and which devices)
+ - Prevent two domains types from communicating via event channels or grants
+ - Control which type of domains can use device passthrough (and which devices)

I disagree with this snippet. This is an example of what you can do with
FLASK. You can use flask to do those two actions. Adding the word
"types" in there takes it from being a concrete example to being more
ambiguous.
"Prevent domains belonging to different types to communicate via event channels or 
grants". Does this sounds better.

I think that its important to use the word "type" so that user doesn't get a 
wrong impression that the policy is per domain, while in actual its per type.

I think it would be clearer to leave the examples as is, but add a sentence to 
the
following paragraph about how the policy is written based on types.

For the other changes, I agree Doug's rewording is a bit clearer than the 
original.

--
Daniel De Graaf
National Security Agency

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.