Re: [Xen-devel] [PATCH v2] xl: add option to leave domain paused after migration

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 07/19/2016 04:58 AM, Roger Pau Monne wrote:
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index d8530f0..fd80442 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -4742,7 +4742,7 @@ static void migrate_domain(uint32_t domid, const char 
> *rune, int debug,
>      exit(EXIT_FAILURE);
>  }
>  
> -static void migrate_receive(int debug, int daemonize, int monitor,
> +static void migrate_receive(int debug, int daemonize, int monitor, int pause,

This causes a name shadowing error on an old compiler:

cc1: warnings being treated as errors
xl_cmdimpl.c: In function ‘migrate_receive’:
xl_cmdimpl.c:4781: error: declaration of ‘pause’ shadows a global
declaration
/usr/include/unistd.h:466: error: shadowed declaration is here
xl_cmdimpl.c: In function ‘main_migrate_receive’:
xl_cmdimpl.c:5008: error: declaration of ‘pause’ shadows a global
declaration
/usr/include/unistd.h:466: error: shadowed declaration is here
xl_cmdimpl.c: In function ‘main_migrate’:
xl_cmdimpl.c:5094: error: declaration of ‘pause’ shadows a global
declaration
/usr/include/unistd.h:466: error: shadowed declaration is here
make: *** [xl_cmdimpl.o] Error 1

FC-64 <build@build-mk2:~/xtt-x86_64/bootstrap/xen/tools/libxl> gcc
--version | head -1
gcc (GCC) 4.4.4 20100503 (Red Hat 4.4.4-2)
FC-64 <build@build-mk2:~/xtt-x86_64/bootstrap/xen/tools/libxl> grep
pause /usr/include/unistd.h
extern int pause (void);
FC-64 <build@build-mk2:~/xtt-x86_64/bootstrap/xen/tools/libxl>



-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel