Re: [Xen-devel] [PATCH 0/6] libxl: extend device type framework

[Juergen Gross <jgross@xxxxxxxx>]

On 12/07/16 17:30, Juergen Gross wrote:
> Extend the device type framework in libxl to cover more functions in a
> generic way. This allows to have all functionality of a specific device
> type in just one source file instead of spreading it via multiple files
> and have functions to deal with multiple device types in a similar way.
> 
> Some patches of this series can be regarded as RFC, as having e.g. all
> nic related functions in one file is a matter of taste. I haven't
> marked the patches as RFC as they are completely tested and I believe
> the result is an improvement over current status.
> 
> Juergen Gross (6):
>   libxl: add "merge" function to generic device type support
>   libxl: add "pv device mode needed" support to device type framework
>   libxl: move library pvusb specific code into libxl_pvusb.c
>   libxl: split libxl vtpm code into one source
>   libxl: add config update callback to device type framework
>   libxl: move common nic stuff into one source
> 
>  tools/libxl/Makefile         |   1 +
>  tools/libxl/libxl.c          | 930 
> ++++++-------------------------------------
>  tools/libxl/libxl_create.c   |  35 +-
>  tools/libxl/libxl_dm.c       |  31 +-
>  tools/libxl/libxl_internal.c |  21 +-
>  tools/libxl/libxl_internal.h |  77 ++--
>  tools/libxl/libxl_nic.c      | 554 ++++++++++++++++++++++++++
>  tools/libxl/libxl_pci.c      |   8 +-
>  tools/libxl/libxl_pvusb.c    |  42 +-
>  tools/libxl/libxl_utils.c    |  96 -----
>  tools/libxl/libxl_vtpm.c     | 380 ++++++++++++++++++
>  11 files changed, 1192 insertions(+), 983 deletions(-)
>  create mode 100644 tools/libxl/libxl_nic.c
>  create mode 100644 tools/libxl/libxl_vtpm.c
> 

Any comments on this series?


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel