Re: [Xen-devel] [PATCH 2/2] systemd: drop dependency on proc-xen.mount in xendriverdomain.service

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Jul 24, 2016 at 09:27:13PM +0200, Marek Marczykowski-Górecki wrote:
> It is no longer required since xl devd use /dev/xen interface.
> 

How would this unit work when there is no /dev/xen interface?

To be precise, we prefer /dev/xen interfaces whenever possible but there
is a fallback to /proc/xen. Note that a lot of other unit files have
this dependency on proc-xen.mount.

I'm inclined to say we should keep this dependency but I'm not sure if I
missed some obvious things.

> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> ---
>  tools/hotplug/Linux/systemd/xendriverdomain.service.in | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/hotplug/Linux/systemd/xendriverdomain.service.in 
> b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> index 0afb54d..a100309 100644
> --- a/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> +++ b/tools/hotplug/Linux/systemd/xendriverdomain.service.in
> @@ -1,7 +1,5 @@
>  [Unit]
>  Description=Xen driver domain device daemon
> -Requires=proc-xen.mount
> -After=proc-xen.mount
>  ConditionVirtualization=xen
>  
>  [Service]
> -- 
> 2.5.5



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel