Re: [Xen-devel] [PATCH v1 14/20] acpi: Move ACPI code to tools/libacpi

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.07.16 at 21:05, <boris.ostrovsky@xxxxxxxxxx> wrote:
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with a suggestion and a minor remark:

> @@ -90,16 +87,20 @@ ROMS += $(SEABIOS_ROM)
>  endif
>  
>  .PHONY: all
> -all: subdirs-all
> +all: acpi subdirs-all
>       $(MAKE) hvmloader
>  
> +.PHONY: acpi
> +acpi:
> +     $(MAKE) -C $(ACPI_PATH)  ACPI_BUILD_DIR=$(shell pwd)

$(CURDIR) ?

> @@ -153,6 +154,7 @@ endif
>  clean: subdirs-clean
>       rm -f roms.inc roms.inc.new acpi.h
>       rm -f hvmloader hvmloader.tmp *.o $(DEPS)
> +     $(MAKE) -C $(ACPI_PATH)  ACPI_BUILD_DIR=$(shell pwd) clean

Again.

> --- a/tools/firmware/hvmloader/acpi/Makefile
> +++ b/tools/libacpi/Makefile
> @@ -14,7 +14,7 @@
>  # this program; If not, see <http://www.gnu.org/licenses/>.
>  #
>  
> -XEN_ROOT = $(CURDIR)/../../../..
> +XEN_ROOT = $(CURDIR)/../../

Not how the original does not end in a slash.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel