Re: [Xen-devel] [PATCH] x86/hvm: Drop the info level HVM save/restore messages

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.08.16 at 15:41, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 04/08/16 08:41, Jan Beulich wrote:
>>>>> On 03.08.16 at 20:26, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> These are not very useful at all, and overly voluminous since the domain
>>> builder switched to using XEN_DOMCTL_{get,set}hvmcontext to construct HVM
>>> domains.
>> I have to admit that I like to have them for restore, but I'm with
>> you that they're quite useless for domain construction. Could we
>> alternatively switch them to dprintk() (or, to avoid file/line getting
>> printed, make them conditional upon !NDEBUG) and/or
>> XENLOG_G_DEBUG?
> 
> That would be an improvement, but still leaves the domain construction
> messages around (which is my real purpose here).
> 
> However, I can't think of any easy way of distinguishing domain
> construction from restore.

Neither can I (does the ordering of the operations here vs memory
population perhaps differ?), but in that case I'd rather like to keep
the messages (but perhaps turn their severity down, albeit I guess
that wouldn't help you).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel