[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 06/23] acpi/hvmloader: Collect processor and NUMA info in hvmloader



>>> On 09.08.16 at 15:43, <boris.ostrovsky@xxxxxxxxxx> wrote:
> On 08/09/2016 09:27 AM, Jan Beulich wrote:
>>>>> On 04.08.16 at 23:06, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>> ---
>>> v2:
>>> * Note: struct acpi_numa's pointers can't be constified due to their
>>>   use in later patches
>> Well, I hope I'll remember once I get there.
> 
> Patch 22, init_acpi_config() routine.

Thanks.

>>> --- a/tools/firmware/hvmloader/acpi/build.c
>>> +++ b/tools/firmware/hvmloader/acpi/build.c
>>> @@ -70,7 +70,8 @@ static void set_checksum(
>>>      p[checksum_offset] = -sum;
>>>  }
>>>  
>>> -static struct acpi_20_madt *construct_madt(struct acpi_info *info)
>>> +static struct acpi_20_madt *construct_madt(struct acpi_config *config,
>> const? (I'm btw going to take the liberty to fix up patch 2 in this
>> regard when committing it later today, 
> 
> Keep in mind that this series is blocked by re-licensing not yet having
> been acked by all parties. This affects the series starting with a later
> patch (the one that moves files to tools/, patch 14) but I am not sure
> it's worth committing early patches only. Patch 15 is the only exception.

Well, primarily I wanted to reduce the amount of necessary resends.
Since the initial patches shouldn't break anything, I think committing
them should be fine. Unless you tell me not to, of course.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.