[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [OSSTEST PATCH 1/7] duration_estimator: Introduce $duration_duration_qtxt and @d_d_args



This is going to make it easier to, conditionally, make this query
more complicated.

No functional change.

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
---
 Osstest/Executive.pm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index 7a35a19..a57ea55 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -1056,12 +1056,14 @@ END
 END
     # s J J J # fix perl-mode
 
-    my $duration_duration_q= $dbh_tests->prepare(<<END);
+    my $duration_duration_qtxt= <<END;
             SELECT sum(finished-started) AS duration FROM steps
                          WHERE flight=? AND job=?
                             AND step != 'ts-hosts-allocate'
 END
 
+    my $duration_duration_q = $dbh_tests->prepare($duration_duration_qtxt);
+
     return sub {
         my ($job, $hostidname, $onhost) = @_;
 
@@ -1098,7 +1100,8 @@ END
 
         my $duration_max= 0;
         foreach my $ref (@$refs) {
-            $duration_duration_q->execute($ref->{flight}, $job);
+           my @d_d_args = ($ref->{flight}, $job);
+            $duration_duration_q->execute(@d_d_args);
             my ($duration) = $duration_duration_q->fetchrow_array();
             $duration_duration_q->finish();
             if ($duration) {
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.