Re: [Xen-devel] [PATCH] Remove ambiguities in the COPYING file; add CONTRIBUTING file

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 11/08/2016 19:57, "Stefano Stabellini" <sstabellini@xxxxxxxxxx> wrote:

>On Thu, 11 Aug 2016, George Dunlap wrote:
>> On 11/08/16 01:51, Stefano Stabellini wrote:
>> > On Wed, 10 Aug 2016, Lars Kurth wrote:
>>
>> >> diff --git a/CONTRIBUTING b/CONTRIBUTING
>> >> new file mode 100644
>> >> index 0000000..7af13c4
>> >> --- /dev/null
>> >> +++ b/CONTRIBUTING
>> >> @@ -0,0 +1,210 @@
>> >> +
>> >> +CONTRIBUTING
>> >> +============
>> >> +
>> >> +INBOUND LICENSE
>> >> +---------------
>> >> +
>> >> +Contributions are governed by the license that applies to relevant
>> >> +specific file or by the license specified in the COPYING file, that
>> >              ^files
>> 
>> I think "file" is better here, as the license is on a file-by-file
>> basis, not on a whole contribution basis.  That is, if your contribution
>> changes a BSD file and a GPLv2 file in a single series (or a single
>> patch), then the changes to the BSD file are goverened by the BSD
>> licence, and the changes to the GPLv2 file are governed by the GPLv2.
>
>OK, I understand the intention behind that sentence but it sounds odd to
>me (possibly because I am not a native English speaker so if it is
>technically correct, you might want to ignore my comment).
>Shouldn't it be:
>
>    to _a_ relevant specific file

I will fix this. I think probably _the_ instead of _a_ is better. Next
revision coming.
Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel