Re: [Xen-devel] [PATCH 1/2] x86: force suitable alignment in sources rather than in linker script

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.08.16 at 17:02, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 12/08/16 15:47, Jan Beulich wrote:
>> Besides being more logical this also allows verifying correct recording
>> of alignments in .o files.
>>
>> The cpu0_stack related ASSERT() in xen.lds.S is now of questionable
>> value (as it now verifies correct tool chain behavior), but I've left
>> it in nevertheless.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -89,6 +89,7 @@ struct hvm_function_table hvm_funcs __re
>>   */
>>  #define HVM_IOBITMAP_SIZE (3 * PAGE_SIZE)
>>  unsigned long __section(".bss.page_aligned")
>> +    __attribute__((aligned(PAGE_SIZE)))
> 
> Can I talk you into introducing #define __aligned(x)
> __attribute__((aligned(x))) in compiler.h ?

Sure, I was on the edge of introducing it while putting this together
anyway, but then thought it's maybe not worth it.

> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel