Re: [Xen-devel] [PATCH 3/4] x86emul: drop SrcInvalid

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.08.16 at 12:12, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/08/16 09:35, Jan Beulich wrote:
>> As of commit a800e4f611 ("x86emul: drop pointless and add useful
>> default cases") we no longer need the early bailing when "d == 0" (the
>> default cases in the main switch() statements take care of that),
>> removal of which renders internal_error() wrong and SrcInvalid useless.
> 
> "the removal of which".

Is the article really necessary in that case? So far I thought I had
learned it's optional in such situations.

> However, SrcInvalid is already unused, irrespective of internal_error().

Well, it's not explicitly referenced, but it having been zero and
the zero checks now getting dropped ...

> I don't however see how this renders internal_error() incorrect.

... both callers of internal_error() need to go away (perhaps I
simply used unclear wording, which obviously I could improve:
"renders both callers of internal_error() wrong"). IOW it is now
no longer an internal error to reach these default labels.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel