[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 04/16] generic-sections: add section core helpers
- To: Kees Cook <keescook@xxxxxxxxxxxx>
- From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
- Date: Tue, 23 Aug 2016 01:13:03 +0200
- Cc: "gnomes@xxxxxxxxxxxxxxxxxxx" <gnomes@xxxxxxxxxxxxxxxxxxx>, linux-ia64@xxxxxxxxxxxxxxx, Jiri Kosina <jkosina@xxxxxxx>, "benh@xxxxxxxxxxxxxxxxxxx" <benh@xxxxxxxxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxxxxx>, Heiko Carstens <heiko.carstens@xxxxxxxxxx>, platform-driver-x86@xxxxxxxxxxxxxxx, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>, linux-arch <linux-arch@xxxxxxxxxxxxxxx>, markus.heiser@xxxxxxxxxxx, sparclinux <sparclinux@xxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>, linux-sh <linux-sh@xxxxxxxxxxxxxxx>, Will Deacon <will.deacon@xxxxxxx>, 조경민 <korea.drzix@xxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, anil.s.keshavamurthy@xxxxxxxxx, fontana@xxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, Catalin Marinas <catalin.marinas@xxxxxxx>, dvhart@xxxxxxxxxxxxx, David Woodhouse <dwmw2@xxxxxxxxxxxxx>, David Vrabel <david.vrabel@xxxxxxxxxx>, linux-xtensa@xxxxxxxxxxxxxxxx, pali.rohar@xxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Miao Steven <realmz6@xxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxx>, Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, jbaron@xxxxxxxxxx, ananth@xxxxxxxxxxxxxxxxxx, Borislav Petkov <bp@xxxxxxxxx>, Josh Poimboeuf <jpoimboe@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>, Michael Brown <mcb30@xxxxxxxx>, linux-kbuild <linux-kbuild@xxxxxxxxxxxxxxx>, Alan Cox <alan@xxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Chris Zankel <chris@xxxxxxxxxx>, Paul Bolle <pebolle@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, "ananth@xxxxxxxxxx" <ananth@xxxxxxxxxx>, Max Filippov <jcmvbkbc@xxxxxxxxx>, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxxxxxxxxxx>, "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>, Michal Marek <mmarek@xxxxxxxx>, Mark Salter <msalter@xxxxxxxxxx>, mhiramat@xxxxxxxxxx, jolsa@xxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
- Delivery-date: Mon, 22 Aug 2016 23:13:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Fri, Aug 19, 2016 at 02:47:48PM -0700, Kees Cook wrote:
> On Fri, Aug 19, 2016 at 2:32 PM, <mcgrof@xxxxxxxxxx> wrote:
> > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
> >
> > +SECTION_RODATA
> > +--------------
> > +.. kernel-doc:: include/asm-generic/section-core.h
> > + :doc: SECTION_RODATA
> > +
> > +SECTION_RODATA
>
> Typo: should this be called SECTION_TEXT instead?
Fixed thanks.
> > +--------------
> > +.. kernel-doc:: include/asm-generic/section-core.h
> > + :doc: SECTION_TEXT
> > +
> > +SECTION_DATA
> > +------------
> > +.. kernel-doc:: include/asm-generic/section-core.h
> > + :doc: SECTION_DATA
>
> Missing from this list are things like the __read_mostly
> (".data..read_mostly") and __ro_after_init (".data..ro_after_init")
> sections. Should those be included too, or are you only doing the "top
> level" sections?
I'm doing top level right now just to start off and get the
bikeshedding out of the way. We can add more with more time
or as we port more things or as the need arises.
Luis
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
