Re: [Xen-devel] mkelf32 incorrectly filling out the program headers for NOTE

[Sylvain Munaut <s.munaut@xxxxxxxxxxxxxxxxxxxx>]

Hi Jan,


> Indeed, patch in the works. But why did you not provide a patch
> yourself, considering that you've done all the diagnosis?

I read the code of that tool this morning and couldn't really
understand how "offset" was computed.

I was seeing :

offset = in64_phdr.p_offset;

then a bit later

offset = in64_phdr.p_offset - offset;

which made no sense to me and so decided I'd better not meddle with
things I didn't understand.


Re-reading it now a bit more awake, I see I completely overlooked that
in64_phdr is changed in the mean time (duh ! not sure how I missed it)
...
I could also have looked at how out_shdr_note.sh_offset is assigned
since that one seems correct and notice the missing RAW_OFFSET.


Next time, I'll give it a fresh second look a day later before
posting, sorry about that.


Cheers,

    Sylvain

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel