Re: [Xen-devel] [PATCH] VT-d: drop pointless uses of __func__

["Wu, Feng" <feng.wu@xxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Thursday, August 25, 2016 2:45 PM
> To: Wu, Feng <feng.wu@xxxxxxxxx>
> Cc: Tian, Kevin <kevin.tian@xxxxxxxxx>; xen-devel <xen-
> devel@xxxxxxxxxxxxxxxxxxxx>
> Subject: RE: [PATCH] VT-d: drop pointless uses of __func__
> 
> >>> On 25.08.16 at 03:08, <feng.wu@xxxxxxxxx> wrote:
> >> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> >> Subject: [PATCH] VT-d: drop pointless uses of __func__
> >> --- a/xen/drivers/passthrough/vtd/iommu.c
> >> +++ b/xen/drivers/passthrough/vtd/iommu.c
> >> @@ -129,11 +129,11 @@ static int context_get_domain_id(struct
> >>
> >>          dom_index = context_domain_id(*context);
> >>
> >> -        if ( dom_index < nr_dom && iommu->domid_map)
> >> +        if ( dom_index < nr_dom && iommu->domid_map )
> >>              domid = iommu->domid_map[dom_index];
> >>          else
> >> -            dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds
> >> nr_dom %lu or iommu has no domid_map\n",
> >> -                    __func__, dom_index, nr_dom);
> >> +            dprintk(XENLOG_DEBUG VTDPREFIX, "dom_index %lu exceeds
> >> nr_dom %lu or iommu has no domid_map\n",
> >
> > This line exceeds the 80 characters limitation, do we have better way to
> > handle this?
> 
> Indeed; I had noticed this too (after sending) and intend to break
> it like this:
> 
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -129,11 +129,12 @@ static int context_get_domain_id(struct
> 
>          dom_index = context_domain_id(*context);
> 
> -        if ( dom_index < nr_dom && iommu->domid_map)
> +        if ( dom_index < nr_dom && iommu->domid_map )
>              domid = iommu->domid_map[dom_index];
>          else
> -            dprintk(XENLOG_DEBUG VTDPREFIX, "%s: dom_index %lu exceeds
> nr_dom %lu or iommu has no domid_map\n",
> -                    __func__, dom_index, nr_dom);
> +            dprintk(XENLOG_DEBUG VTDPREFIX,
> +                    "dom_index %lu exceeds nr_dom %lu or iommu has no
> domid_map\n",
> +                    dom_index, nr_dom);

Looks good to me.

Reviewed-by Feng Wu <feng.wu@xxxxxxxxx>

Thanks,
Feng

>      }
>      return domid;
>  }
> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel