Re: [Xen-devel] [PATCH] stubdom: support Mini-OS config for Mini-OS apps

[Juergen Gross <jgross@xxxxxxxx>]

On 30/08/16 15:52, Wei Liu wrote:
> On Tue, Aug 30, 2016 at 01:52:40PM +0200, Juergen Gross wrote:
>> Mini-OS apps need to be compiled with the appropriate config settings
>> of Mini-OS, as there are various dependencies on those settings in
>> header files included by the apps.
>>
>> Enhance stubdom Makefile to set the appropriate CPPFLAGS when calling
>> the apps' make.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> ---
>>  stubdom/Makefile            | 48 
>> +++++++++++++++++++++++++++++++++------------
>>  stubdom/xenstore-minios.cfg |  1 +
> 
> Changes to gitignore is missing.

Right. And I thought of it in the corresponding Mini-OS patch. Going to
fetch some coffee...

> And, do I need to update mini-os commit in Config.mk here as well?

Yeah, I'll add that info.

> The code looks fine to me.

Thanks,

Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel