[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] make use of .startof.() and .sizeof.() assembler expressions



>>> On 30.08.16 at 15:18, <julien.grall@xxxxxxx> wrote:
> On 30/08/16 14:09, Jan Beulich wrote:
>>>>> On 30.08.16 at 14:50, <julien.grall@xxxxxxx> wrote:
>>> If you want to add it, it should be a separate patch and we should go
>>> further by removing the section in the linker script.
>>
>> While I don't think this needs to be broken out, it certainly can (but
>> then really there should have been a conditional like the one I
>> introduce from the beginning, to avoid having dead code in a non-
>> ACPI enabled binary).
> 
> It was an oversight while reviewing the patch adding acpi_device_init 
> and I thought you added CONFIG_ACPI just for comestic.

So with that, do you then still require me to split this off?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.