Re: [Xen-devel] [PATCH 1/4] arm: acpi/boot.c is only used during initialisation

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 30/08/16 13:01, Wei Liu wrote:
> That file should contain code and data used during initialisation only.
>
> Mark it as such in build system and correctly annotate enabled_cpus.
> This is required to enable gcov support on ARM.
I am not sure to understand the requirement here. Does it mean it is not 
possible to have a mix of init code and runtime code?
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Regardless the questions:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

> ---
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>
> ---
>  xen/arch/arm/acpi/Makefile | 2 +-
>  xen/arch/arm/acpi/boot.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/acpi/Makefile b/xen/arch/arm/acpi/Makefile
> index 196c40a..23963f8 100644
> --- a/xen/arch/arm/acpi/Makefile
> +++ b/xen/arch/arm/acpi/Makefile
> @@ -1,2 +1,2 @@
>  obj-y += lib.o
> -obj-y += boot.o
> +obj-y += boot.init.o
> diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c
> index 28b3450..c3242a0 100644
> --- a/xen/arch/arm/acpi/boot.c
> +++ b/xen/arch/arm/acpi/boot.c
> @@ -37,7 +37,7 @@
>  #include <asm/setup.h>
>
>  /* Processors with enabled flag and sane MPIDR */
> -static unsigned int enabled_cpus = 1;
> +static unsigned int __initdata enabled_cpus = 1;
>  static bool __initdata bootcpu_valid;
>
>  /* total number of cpus in this system */
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel