Re: [Xen-devel] [PATCH 3/3] mini-os: support "make config" for out-of-tree users

[Juergen Gross <jgross@xxxxxxxx>]

On 30/08/16 23:38, Samuel Thibault wrote:
> Hello,
> 
> Juergen Gross, on Tue 30 Aug 2016 13:51:23 +0200, wrote:
>> @@ -51,7 +51,7 @@ endif
>>  
>>  libc = $(stubdom)
>>  
>> -XEN_INTERFACE_VERSION := 0x00030205
>> +XEN_INTERFACE_VERSION ?= 0x00030205
> 
> Why making it overridable?  AIUI changing the version would change the
> xen headers API, and thus the existing mini-os source would possibly not
> even compile any more.  I also don't see the relation with the commit
> log :)

Hmm, I should have included more reasoning.

I stumbled over the problem with xenstore-stubdom: xenstore is using
__XEN_LATEST_INTERFACE_VERSION__ when being compiled. This produced a
build error with Mini-OS (console_evtchn in include/console.h was
#define'd to console.domU.evtchn by include/xen/xen.h). It was pure
luck such a problem didn't occur before my recent changes.

I think it is much more reasonable to compile all parts of a stubdom
with the same Xen interface version instead of letting use the core of
Mini-OS an ancient version and the App using Mini-OS another one. So I
added XEN_INTERFACE_VERSION to be configurable.

This requires some adjustments in Mini-OS, of course. That is the
purpose of patch 1 of this series.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel