[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] libelf: drop pointless uses of __FUNCTION__



On 06/09/16 16:10, Jan Beulich wrote:
> --- a/xen/common/libelf/libelf-loader.c
> +++ b/xen/common/libelf/libelf-loader.c
> @@ -33,7 +33,7 @@ elf_errorstatus elf_init(struct elf_bina
>  
>      if ( !elf_is_elfbinary(image_input, size) )
>      {
> -        elf_err(elf, "%s: not an ELF binary\n", __FUNCTION__);
> +        elf_err(elf, "not an ELF binary\n");

Omitted the ELF prefix.  Despite the wording of the error message, it
would be better to put out consistent errors.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.