Re: [Xen-devel] [PATCH v2 13/20] livepatch: Initial ARM64 support.

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Aug 25, 2016 at 09:02:48AM -0600, Jan Beulich wrote:
> >>> On 25.08.16 at 15:37, <konrad.wilk@xxxxxxxxxx> wrote:
> > --- a/xen/include/xen/types.h
> > +++ b/xen/include/xen/types.h
> > @@ -14,6 +14,12 @@
> >  #define NULL ((void*)0)
> >  #endif
> >  
> > +#define U16_MAX         ((u16)~0U)
> > +#define S16_MAX         ((s16)(U16_MAX>>1))
> > +#define S16_MIN         ((s16)(-S16_MAX - 1))
> > +#define U32_MAX         ((u32)~0U)
> > +#define S32_MAX         ((s32)(U32_MAX>>1))
> > +#define S32_MIN         ((s32)(-S32_MAX - 1))
> 
> These are rather strange constants: Fixed width types necessarily
> always have the same boundaries of representable values. Otoh
> the C standard has such constants too - maybe if we really want
> them we should rather use their names?

I got these from the Linux kernel - which may have added these
before the C99 standard.

But I agree that using the C ones should make this easier, so I pulled
them in from /usr/include/stdint.h
> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel