Re: [Xen-devel] [PATCH v3 18/19] libxl/acpi: Build ACPI tables for HVMlite guests

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 09/08/2016 10:20 AM, Jan Beulich wrote:
>>
>>  
>>  /*
>> diff --git a/tools/libacpi/libacpi.h b/tools/libacpi/libacpi.h
>> index d803139..b0ff5aa 100644
>> --- a/tools/libacpi/libacpi.h
>> +++ b/tools/libacpi/libacpi.h
>> @@ -48,6 +48,15 @@ struct acpi_ctxt {
>>          void (*free)(struct acpi_ctxt *ctxt, void *v, uint32_t size);
>>          unsigned long (*v2p)(struct acpi_ctxt *ctxt, void *v);
>>      } mem_ops;
>> +
>> +    unsigned int page_size;
>> +    unsigned int page_shift;
>> +
>> +    /* Memory allocator */
>> +    unsigned long alloc_base_paddr;
>> +    unsigned long alloc_base_vaddr;
>> +    unsigned long alloc_currp;
>> +    unsigned long alloc_end;
>>  };
> There not being (or getting added) any users of these in libacpi/, I
> wonder how this is related to the subject of the patch. If this is
> data that only libxl needs for its own purposes, then surely this
> shouldn't get added to struct acpi_ctxt, but should be a libxl
> private extension of that structure.

struct acpi_ctxt {
    ...

    void *private;
};

?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel