Re: [Xen-devel] [PATCH v3 14/38] arm/p2m: Add altp2m init/teardown routines

[Sergej Proskurin <proskurin@xxxxxxxxxxxxx>]

Hi Julien,


>>>  struct arch_vcpu
>>> diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
>>> index 1a004ed..de0c90a 100644
>>> --- a/xen/include/asm-arm/p2m.h
>>> +++ b/xen/include/asm-arm/p2m.h
>>> @@ -9,6 +9,8 @@
>>>  #include <xen/p2m-common.h>
>>>  #include <public/memory.h>
>>>
>>> +#define MAX_ALTP2M 10           /* ARM might contain an arbitrary
>>> number of
>>> +                                   altp2m views. */
>> This should belong to altp2m.h and not p2m.h
>>
> Unfortunately, this won't work. We cannot move this define into altp2m.h
> as it would result in an header conflict: The header asm/altp2m.h
> includes xen/domain.h, which in turn includes asm/domain.h. So by
> including asm/altp2m.h in asm/domain.h (as MAX_ALTP2M is used there), we
> would create a loop of header dependencies.

Sorry, I forgot one header: altp2m.h includes xen/sched.h, which in turn
includes xen/domain.h and so on.

Cheers,
~Sergej


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel