[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 4/5] x86/time: implement PVCLOCK_TSC_STABLE_BIT



>>> On 14.09.16 at 19:37, <joao.m.martins@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/time.c
> +++ b/xen/arch/x86/time.c
> @@ -951,6 +951,14 @@ static void __update_vcpu_system_time(struct vcpu *v, 
> int force)
>      _u.tsc_timestamp = tsc_stamp;
>      _u.system_time   = t->stamp.local_stime;
>  
> +    /*
> +     * It's expected that domains cope with this bit changing on every
> +     * pvclock read to check whether they can resort solely on this tuple
> +     * or if it further requires monotonicity checks with other vcpus.
> +     */
> +    if ( clocksource_is_tsc() )
> +        _u.flags    |= XEN_PVCLOCK_TSC_STABLE_BIT;

Stray blanks ahead of the |=.

With that taken care of
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.