Re: [Xen-devel] [PATCH v5 16/16] libxl/arm: Add the size of ACPI tables to maxmem

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Julien Grall writes ("Re: [PATCH v5 16/16] libxl/arm: Add the size of ACPI 
tables to maxmem"):
> On 13/09/16 08:03, Shannon Zhao wrote:
...
> >> xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb +
> >> LIBXL_MAXMEM_CONSTANT + libxl__arch_memory_constant());
> >>
> >> Or a similar name.
> >>
> > Just to confirm, do you mean that having a arch function to get the size
> > each arch needs and adding the size in libxl__build_pre()?
> 
> That's correct. Wei, Ian, do you have any opinions on this?

Yes, I think Julien's suggestion is a good one.  The name is fine IMO.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel