Re: [Xen-devel] [PATCH] tools: lift BUILD_BUG_ON to a tools header file

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 19/09/16 17:46, Wei Liu wrote:
> On Mon, Sep 19, 2016 at 04:07:30PM +0100, Wei Liu wrote:
> > Only define BUILD_BUG_ON when there isn't one already, because mini-os
> > currently leaks that.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Paulina Szubarczyk <paulinaszubarczyk@xxxxxxxxx>
> >
> > This is a patch taken out of my branch to clean up some build system
> > issues. It is still a bit ugly because BUILD_BUG_ON is conditionally
> > defined to work around mini-os leaking BUILD_BUG_ON.
> >
> > Either this patch or "[PATCH v2] libs/gnttab: introduce
> > XENGNTTAB_BUILD_BUG_ON" should be taken to unblock Paulina's work.
> > ---
> >   tools/firmware/hvmloader/rombios.c |  1 +
> >   tools/firmware/hvmloader/smbios.c  |  1 +
> >   tools/firmware/hvmloader/util.h    |  1 -
> Oops, I just realise that these changes need an ack from Jan / Andrew.
>
> Jan and Andrew: Since  I can do a partial revert if you're not happy
> with those changes.
>
> Sorry for not having CC'ed you two earlier.
HVMLoader really should be standalone IMO.

However, while you are fixing that, can you also fix the broken header 
guard for xen-tools/libs.h ?
~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel