[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/2] x86: add a user configurable Kconfig option for the NS16550 UART

>>> On 19.09.16 at 16:51, <derek@xxxxxxxxxxx> wrote:
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -1,6 +1,11 @@
>  config HAS_NS16550
>       bool
>       default y
> +
> +config NS16550
> +     bool "NS16550 UART" if EXPERT = "y"
> +     default y
> +     depends on HAS_NS16550
>       help
>         This selects the 16550-series UART support. For most systems, say Y.

May I please ask to avoid sending new patch versions without fully
taking care of earlier comments? I'm still missing the overview mail
as indicated in reply to the VGA sibling of these two patches. And
I did clearly say "rename" when talking about the aspects of HAS_*
Kconfig variables - you're leaving HAS_NS16550 as a completely
pointless variable around the way you've done it.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.