[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 12/16] bug/x86/arm: Align bug_frames sections.

Hi Konrad,

On 19/09/2016 22:19, Konrad Rzeszutek Wilk wrote:
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

I forgot to mention that with those NITs fixed:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>


However I noticed (and I recall having it replaced in earlier
versions so I must have in a hurry missed it), but this:

--- a/xen/include/asm-arm/bug.h
+++ b/xen/include/asm-arm/bug.h
@@ -52,6 +52,7 @@ struct bug_frame {

".popsection\n"                                                    \
          ".pushsection .bug_frames." __stringify(type) ", \"a\",

"4:\n"                                                             \
+         ".align 4\n"                                                       \

[fixed up, your mailer mangled it]
This should have been:

diff --git a/xen/include/asm-arm/bug.h b/xen/include/asm-arm/bug.h
index 773d63e..affe64f 100644
--- a/xen/include/asm-arm/bug.h
+++ b/xen/include/asm-arm/bug.h
@@ -52,7 +52,7 @@ struct bug_frame {
          ".popsection\n"                                                    \
          ".pushsection .bug_frames." __stringify(type) ", \"a\", %progbits\n"\
          "4:\n"                                                             \
-         ".align 4\n"                                                       \
+         ".p2align 4\n"                                                     \
          ".long (1b - 4b)\n"                                                \
          ".long (2b - 4b)\n"                                                \
          ".long (3b - 4b)\n"                                                \

So that it would be in sync with x86 version.

The end result is exactly the same - it is just that p2align is
preferred because it has the same semantics across platforms while
.align differs.

I made the change (along with your recommendations) and put your
Reviewed-by. I hope that is OK.

I am fine with that.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.