Re: [Xen-devel] [PATCH v4 01/21] acpi: Extract acpi info description into a separate ASL file

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 09/21/2016 06:29 AM, Jan Beulich wrote:
>>>> On 20.09.16 at 02:19, <boris.ostrovsky@xxxxxxxxxx> wrote:
>> --- a/tools/firmware/hvmloader/acpi/Makefile
>> +++ b/tools/firmware/hvmloader/acpi/Makefile
>> @@ -33,13 +33,15 @@ ssdt_s3.h ssdt_s4.h ssdt_pm.h ssdt_tpm.h: %.h: %.asl iasl
>>  mk_dsdt: mk_dsdt.c
>>      $(HOSTCC) $(HOSTCFLAGS) $(CFLAGS_xeninclude) -o $@ mk_dsdt.c
>>  
>> -dsdt_anycpu_qemu_xen.asl: dsdt.asl mk_dsdt
>> +dsdt_anycpu_qemu_xen.asl: dsdt.asl dsdt_acpi_info.asl mk_dsdt
>>      awk 'NR > 1 {print s} {s=$$0}' $< > $@
>> +    cat dsdt_acpi_info.asl >> $@
>>      ./mk_dsdt --debug=$(debug) --dm-version qemu-xen >> $@
>>  
>>  # NB. awk invocation is a portable alternative to 'head -n -1'
>> -dsdt_%cpu.asl: dsdt.asl mk_dsdt
>> +dsdt_%cpu.asl: dsdt.asl dsdt_acpi_info.asl mk_dsdt
>>      awk 'NR > 1 {print s} {s=$$0}' $< > $@
>> +    cat dsdt_acpi_info.asl >> $@
>>      ./mk_dsdt --debug=$(debug) --maxcpu $*  >> $@
> Comments I made on an earlier version now apply here too: In
> order to properly deal with make interruptions or failures, this
> output redirection should be replaced by going through a
> temporary file. Presumably you still have this somewhere later
> in the series (as it iirc was in v3), but imo that should then really
> be moved ahead of the patch here.


Since it looks like I will need to update this Makefile anyway I can
move that patch (#15) to be the first.

-boris

>
> Everything else looks fine.
>
> Jan
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel