Re: [Xen-devel] [PATCH v4 20/21] libxl/acpi: Build ACPI tables for HVMlite guests

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 09/21/2016 11:16 AM, Jan Beulich wrote:
>>>> On 21.09.16 at 17:09, <boris.ostrovsky@xxxxxxxxxx> wrote:
>> On 09/21/2016 07:33 AM, Jan Beulich wrote:
>>>>>> On 20.09.16 at 02:19, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>>> --- a/tools/libacpi/build.c
>>>> +++ b/tools/libacpi/build.c
>>>> @@ -20,6 +20,7 @@
>>>>  #include "ssdt_s4.h"
>>>>  #include "ssdt_tpm.h"
>>>>  #include "ssdt_pm.h"
>>>> +#include <xen/hvm/hvm_info_table.h>
>>> ... I don't really see why this becomes necessary here. Please
>>> clarify.
>> xen/hvm/hvm_info_table.h in included by hvmloader/util.h so we haven't
>> needed this include until now.
> But you're not removing any inclusion here. Does that addition
> perhaps belong elsewhere?

I suppose I can add it to libxl_x86_acpi.h (and remove from
libxl_x86_acpi.c) to be consistent with how it is included by util.h

OTOH, include files that we pass as
-DLIBACPI_STDUTILS=\"$(CURDIR)/<includefile.h.> are intended to provide
declarations for things that are specific to the caller, not to Xen in
general.

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel