Re: [Xen-devel] [PATCH v7 14/14] x86: add multiboot2 protocol support for relocatable images

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.09.16 at 23:47, <daniel.kiper@xxxxxxxxxx> wrote:
> @@ -383,10 +390,19 @@ __start:
>          cmp     %edi,MB2_fixed_total_size(%ebx)
>          jbe     trampoline_bios_setup
>  
> +        /* Get Xen image load base address from Multiboot2 information. */
> +        cmpl    $MULTIBOOT2_TAG_TYPE_LOAD_BASE_ADDR,MB2_tag_type(%ecx)
> +        jne     1f
> +
> +        mov     MB2_load_base_addr(%ecx),%esi
> +        sub     $XEN_IMG_OFFSET,%esi
> +        jmp     9f
> +
> +1:
>          /* Get mem_lower from Multiboot2 information. */
>          cmpl    $MULTIBOOT2_TAG_TYPE_BASIC_MEMINFO,MB2_tag_type(%ecx)
>          cmove   MB2_mem_lower(%ecx),%edx
> -        je      trampoline_bios_setup
> +        je      9f
>  
>          /* EFI IA-32 platforms are not supported. */
>          cmpl    $MULTIBOOT2_TAG_TYPE_EFI32,MB2_tag_type(%ecx)

Considering that you look for another tag type here, doesn't the
branch target change above point out an issue in an earlier patch?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel