Re: [Xen-devel] [PATCH 2/2] tools/configure: fix --with-system-{ovmf/seabios}

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Mon, Sep 26, 2016 at 05:57:00PM +0100, Wei Liu wrote:
> On Mon, Sep 26, 2016 at 06:44:09PM +0200, Roger Pau Monne wrote:
> > Current configure code doesn't define {SEABIOS/OVMF}_PATH when
> > --with-system-{ovmf/seabios} is used. Fix this by making sure those defines
> > are always set if the internal {ovmf/seabios}_path variables are also set.
> > 
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > ---
> > Please re-run autogen.sh before committing.
> > ---
> >  tools/configure.ac | 14 ++++++--------
> >  1 file changed, 6 insertions(+), 8 deletions(-)
> > 
> > diff --git a/tools/configure.ac b/tools/configure.ac
> > index f010d72..6788ea2 100644
> > --- a/tools/configure.ac
> > +++ b/tools/configure.ac
> > @@ -222,10 +222,9 @@ AC_ARG_WITH([system-seabios],
> >          *)  seabios_path=$withval ;;
> >      esac
> >  ],[])
> > -AS_IF([test "x$seabios" = "xy"], [
> > -    AC_DEFINE_UNQUOTED([SEABIOS_PATH],
> > -                       ["${seabios_path:-$XENFIRMWAREDIR/seabios.bin}"],
> > -                       [SeaBIOS path])
> > +AS_IF([test "x$seabios" = "xy"], 
> > [seabios_path=$XENFIRMWAREDIR/seabios.bin])
> > +AS_IF([test -n "$seabios_path"], [
> > +    AC_DEFINE_UNQUOTED([SEABIOS_PATH],["$seabios_path"],[SeaBIOS path])
> >  ])
> 
> What about just change the test condition in the original code to
> 
>   test "x$seabios" = "xy" || -n "$seabios_path"
> 
> ?
>
> That should result in the same thing, right?

Yes, that's right. Should I do it, or are you going to send it? TBH, it's 
just a one line change, and the idea is yours.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel