Re: [Xen-devel] [PATCH v7 14/16] public/hvm/params.h: Add macros for HVM_PARAM_CALLBACK_TYPE_PPI

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.09.16 at 17:27, <shannon.zhao@xxxxxxxxxx> wrote:
> --- a/xen/include/public/hvm/params.h
> +++ b/xen/include/public/hvm/params.h
> @@ -30,6 +30,7 @@
>   */
>  
>  #define HVM_PARAM_CALLBACK_IRQ 0
> +#define HVM_PARAM_CALLBACK_IRQ_TYPE_MASK 0xFF00000000000000ULL

Well, I have to admit that I'm somewhat disappointed: I had
specifically pointed out that the ULL suffix is not C89 conforming,
and that dealing with this may need a little more thought. On the
plus side, the mere presence of that #define won't cause C89
compilers to error out. But to help actually using such a value, I
think we'd better introduce xen_mk_ullong() (next to the two
already existing variants) and use it here and in all other places
wrongly using that C99 construct. That way customization by
such consumers could be limited to exactly one place. If you
wish I can put together the necessary cleanup patch, and you
could then re-base yours on top.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel